WP_PLUGIN/POST_ORDER_BY_ARCHIVE
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

WP PLUGIN　申請指摘事項の再修正

Browse Source 
・echoのエスケープ
・メソッドの変数をエスケープ
This commit is contained in:
nobu
2021-06-18 09:50:16 +09:00
parent 00d6775f77
commit 28c02ebce2
4 changed files with 51 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files
template/order.php
+8 -7
View File
@@ -15,7 +15,8 @@ $submit_type = APOP_UI::input_post_filter( 'apop_submit_type', 'str' );
<div class="post-order-box-outer">
<form action="" method="post">
<?php wp_nonce_field( 'sh_options' ); ?>
<input id="apop_submit_type" type="hidden" name="apop_submit_type" value="<?php echo $submit_type; ?>">
<input id="apop_submit_type" type="hidden" name="apop_submit_type"
value="<?php echo esc_html( $submit_type ); ?>">
<div class="post-order-box">
<div class="list-orders-outer">
<div class="list-orders-inner">
@@ -27,8 +28,8 @@ $submit_type = APOP_UI::input_post_filter( 'apop_submit_type', 'str' );
<?php include APOP_PLUGIN_PATH . 'template/order_parts_menu.php'; ?>
<hr>
<div class="sort_box">
<?php list( $list, $alert ) = APOP_UI::create_search_normal_list( 'normal' ); ?>
<?php echo $alert; ?>
<?php list( $list, $alert) = APOP_UI::create_search_normal_list( 'normal' ); ?>
<p><?php echo esc_html( $alert ); ?></p>
<div class="enable_box">
<h4>有効</h4>
<ul class="post-order-list search_normal_sort">
@@ -41,7 +42,7 @@ $submit_type = APOP_UI::input_post_filter( 'apop_submit_type', 'str' );
</div>
</div>
<div class="sort_box">
<?php echo APOP_UI::none_registered_alert_msg(); ?>
<div class="no_registered_exp">&#9632;は未登録項目です。ドラッグして並び順を変更後に「変更を保存」をクリックしてください。</div>
<ul class="post-order-list drag_sort">
<?php echo APOP_UI::get_all_search_normal_posts( 'normal' ); ?>
</ul>
@@ -60,8 +61,8 @@ $submit_type = APOP_UI::input_post_filter( 'apop_submit_type', 'str' );
<?php include APOP_PLUGIN_PATH . 'template/order_parts_menu.php'; ?>
<hr>
<div class="sort_box">
<?php list( $list, $alert ) = APOP_UI::create_search_normal_list( 'search' ); ?>
<?php echo $alert; ?>
<?php list( $list, $alert) = APOP_UI::create_search_normal_list( 'search' ); ?>
<p><?php echo esc_html( $alert ); ?></p>
<div class="enable_box">
<h4>有効</h4>
<ul class="post-order-list search_normal_sort">
@@ -74,7 +75,7 @@ $submit_type = APOP_UI::input_post_filter( 'apop_submit_type', 'str' );
</div>
</div>
<div class="sort_box">
<?php echo APOP_UI::none_registered_alert_msg(); ?>
<div class="no_registered_exp">&#9632;は未登録項目です。ドラッグして並び順を変更後に「変更を保存」をクリックしてください。</div>
<ul class="post-order-list drag_sort">
<?php echo APOP_UI::get_all_search_normal_posts( 'search' ); ?>
</ul>
template/order_parts_taxonomy.php
+7 -7
View File
@@ -2,10 +2,10 @@
<?php foreach ( $tax_lists as $tax_key => $tax_list ) : ?>
<div class="list-orders-outer">
<?php if ( count( $tax_list ) > 0 ): ?>
<?php echo APOP_UI::none_registered_alert_msg(); ?>
<div class="no_registered_exp">&#9632;は未登録項目です。ドラッグして並び順を変更後に「変更を保存」をクリックしてください。</div>
<?php foreach ( $tax_list as $tax_data ): ?>
<div class="list-orders-inner">
<h3><?php echo esc_html($tax_data->name); ?></h3>
<h3><?php echo esc_html( $tax_data->name ); ?></h3>
<?php
$order_target_data = get_option( '_apop_tax_sort_type' );
if ( isset( $order_target_data[ $tax_data->term_id ] ) ) {
@@ -15,17 +15,17 @@
}
?>
<ul class="sort_menu_list"
data-order_target="<?php echo esc_html($order_target); ?>">
data-order_target="<?php echo esc_html( $order_target ); ?>">
<li>
<label>
<input class="sort_menu" type="radio"
name="_apop_tax_sort_type[<?php echo esc_html($tax_data->term_id); ?>]"
name="_apop_tax_sort_type[<?php echo esc_html( $tax_data->term_id ); ?>]"
value="1"<?php checked( $order_target, 1 ); ?>>ドラッグソート</label>
</li>
<li>
<label>
<input class="sort_menu" type="radio"
name="_apop_tax_sort_type[<?php echo esc_html($tax_data->term_id); ?>]"
name="_apop_tax_sort_type[<?php echo esc_html( $tax_data->term_id ); ?>]"
value="2"<?php checked( $order_target, 2 ); ?>>標準＋カスタムフィールドソート</label>
</li>
</ul>
@@ -37,7 +37,7 @@
</div>
<div class="sort_box">
<?php list( $list, $alert ) = APOP_UI::create_search_normal_list( 'tax', $tax_data->term_id ); ?>
<?php echo $alert; ?>
<p><?php echo esc_html( $alert ); ?></p>
<div class="enable_box">
<h4>有効</h4>
<ul class="post-order-list search_normal_sort">
@@ -52,7 +52,7 @@
</div>
<?php endforeach; ?>
<?php else: ?>
<?php echo APOP_UI::create_none_select_msg( $tax_title_text ); ?>
<p class="no_registered_exp">並べ替えをカスタマイズする<?php echo esc_html( $tax_title_text ); ?>は選択されていません。</p>
<?php endif; ?>
</div>
<?php endforeach; ?>
template/setting_post_custom_field.php
+5 -4
View File
@@ -2,14 +2,15 @@
<?php if ( isset( $this->order_field ) && count( $this->order_field ) > 0 ): ?>
<dl class="apop_setting_list_dd">
<?php foreach ( $this->order_field as $type => $items ): ?>
<dt><?php echo esc_html($this->labels[ $type ]); ?></dt>
<dt><?php echo esc_html( $this->labels[ $type ] ); ?></dt>
<dd>
<ul>
<?php foreach ( $items as $item ): ?>
<?php if ( ! empty( $item ) ): ?>
<li><label><?php echo esc_html($item); ?></label>
<input type="text" name="<?php echo APOP_CUSTOM_FIELD_PREFIX . $item; ?>"
value="<?php echo $this->get_custom_field_data( $item ); ?>"/>
<li><label><?php echo esc_html( $item ); ?></label>
<input type="text"
name="<?php echo esc_html( APOP_CUSTOM_FIELD_PREFIX . $item ); ?>"
value="<?php echo esc_html( $this->get_custom_field_data( $item ) ); ?>"/>
</li>
<?php endif; ?>
<?php endforeach; ?>